feat(client): show + change the configured server URL from the login screen (#235) #238

Merged

james merged 1 commit from 235-login-server-url into main 2026-06-23 12:28:16 +00:00

Conversation 2 Commits 1 Files changed 2 +89 -7

james commented 2026-06-23 12:11:57 +00:00

Owner

Copy link

Summary

Closes #235. Surfaces the configured server URL on the login screen, with a "Change server" link back to /server-setup. Native + Tauri only; PWA returns null since it's always same-origin.

What changed

• New LoginServerRow subcomponent in apps/client/app/login.tsx — gates on Platform.OS !== "web" || isTauriShell(), reads via the same loadServerUrl + subscribe pattern as Account's ServerCard, links via router.replace("/server-setup").
• Two new i18n keys under login: connectedTo and changeServer in packages/i18n/messages/en.json (es stays partial per ADR-0025).
• Pre-flattened plain-object styles on the DOM-leaf Texts (no style={[...]} arrays), per the PR #232 gotcha.

Test plan

• pnpm -F @carol/client typecheck
• pnpm -F @carol/client lint
• pnpm -F @carol/client test — 29 passed
• pnpm -F @carol/client export:web — produces dist/, no layout gap on web

## Summary Closes #235. Surfaces the configured server URL on the login screen, with a "Change server" link back to `/server-setup`. Native + Tauri only; PWA returns null since it's always same-origin. ## What changed - New `LoginServerRow` subcomponent in `apps/client/app/login.tsx` — gates on `Platform.OS !== "web" || isTauriShell()`, reads via the same `loadServerUrl` + `subscribe` pattern as Account's `ServerCard`, links via `router.replace("/server-setup")`. - Two new i18n keys under `login`: `connectedTo` and `changeServer` in `packages/i18n/messages/en.json` (es stays partial per ADR-0025). - Pre-flattened plain-object styles on the DOM-leaf `Text`s (no `style={[...]}` arrays), per the PR #232 gotcha. ## Test plan - [x] `pnpm -F @carol/client typecheck` - [x] `pnpm -F @carol/client lint` - [x] `pnpm -F @carol/client test` — 29 passed - [x] `pnpm -F @carol/client export:web` — produces dist/, no layout gap on web

james added 1 commit 2026-06-23 12:11:57 +00:00

feat(client): show + change the configured server URL from the login screen (#235) ... 1da0a58df6

Add a small row below the login submit button that shows which server
this build is signing in to and a "Change server" link back to the
server-setup screen. Renders only off-origin (native + Tauri); the PWA
returns null with no layout gap since it's always same-origin.

Mirrors the loadServerUrl + subscribe pattern from the Account
ServerCard so a "change server" round-trip stays in sync if the user
comes back to /login.

james referenced this pull request 2026-06-23 12:16:19 +00:00

chore(client): scrub style={[...]} array patterns on DOM-leaf primitives + ESLint guardrail #239

forgejo-actions commented 2026-06-23 12:26:27 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	83.0% ✅	≥ 50%
Branches	75.9% ✅	≥ 75%
Functions	91.3%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 83.0% ✅ | ≥ 50% | | Branches | 75.9% ✅ | ≥ 75% | | Functions | 91.3% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

forgejo-actions commented 2026-06-23 12:27:53 +00:00

Copy link

Trivy (container image)

Threshold: high  ·  Total findings: 121  ·  At/above threshold: 1

critical	high	medium	low
0	1	50	70

severity	id	package	installed / range	fix
high	CVE-2026-12151	undici	6.25.0	6.27.0, 7.28.0, 8.5.0

<!-- scanner-comment: trivy --> ### Trivy (container image) **Threshold:** `high` &nbsp;·&nbsp; **Total findings:** 121 &nbsp;·&nbsp; **At/above threshold:** 1 | critical | high | medium | low | |---:|---:|---:|---:| | 0 | 1 | 50 | 70 | | severity | id | package | installed / range | fix | |---|---|---|---|---| | high | [CVE-2026-12151](https://avd.aquasec.com/nvd/cve-2026-12151) | undici | 6.25.0 | `6.27.0, 7.28.0, 8.5.0` |

james merged commit 55277f7efb into main 2026-06-23 12:28:16 +00:00

james referenced this pull request from a commit 2026-06-23 12:28:18 +00:00

Merge pull request 'feat(client): show + change the configured server URL from the login screen (#235)' (#238) from 235-login-server-url into main

james deleted branch 235-login-server-url 2026-06-23 12:28:19 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!238

No description provided.