feat(client): native clipboard via expo-clipboard (#218) #247

Merged

james merged 1 commit from 218-native-clipboard into main 2026-06-23 16:05:47 +00:00

Conversation 1 Commits 1 Files changed 6 +150 -21

james commented 2026-06-23 13:33:42 +00:00

Owner

Copy link

Summary

Closes #218.

Adds a write-only platform shim for the clipboard so the PAT "Copy" button on /account works on native, not just on the PWA. Inline navigator.clipboard was wrapped in a Platform-check that no-op'd on Android.

Shim shape

apps/client/lib/clipboard.ts:

import * as Clipboard from "expo-clipboard";
import { Platform } from "react-native";

export async function copyToClipboard(text: string): Promise<void> {
  if (Platform.OS === "web") {
    await navigator.clipboard.writeText(text);
    return;
  }
  await Clipboard.setStringAsync(text);
}

• Web (PWA + Tauri webview): navigator.clipboard.writeText.
• Native: expo-clipboard's setStringAsync — bridges to ClipboardManager.setPrimaryClip on Android (no manifest permission required, confirmed in upstream docs) and UIPasteboard on iOS.

Call sites swept

• apps/client/app/(app)/account.tsx — the RevealBanner "Copy" button on the PAT plaintext reveal. The plaintext stays on screen as a manual-copy fallback in case writeText / setStringAsync rejects.

grep -rn "navigator.clipboard" on apps/client/ is otherwise clean.

Dep

• expo-clipboard@~56.0.4 — matches the Expo SDK 56 line (latest dist-tag for the SDK-56 branch).

Test plan

• pnpm install --frozen-lockfile
• pnpm -F @carol/client typecheck / lint / test / export:web
• pnpm -F @carol/api typecheck / lint / test
• pnpm -F @carol/api-client typecheck / lint / test / check
• New tests/clipboard.test.ts exercises both branches via mocks (expo-clipboard mocked on native; navigator.clipboard redefined via Object.defineProperty on web).
• Manual on Android via Expo Go: mint a PAT, tap Copy, paste into another app — round-trips. (To run before merge; documenting here so the manual gate isn't lost.)
• Web (PWA) unchanged — the Platform.OS === "web" branch still calls navigator.clipboard.writeText, and the export still bundles clean.
• No new Android manifest entries (confirmed via upstream docs; expo-clipboard doesn't add a permission).

Acceptance

• Acceptance criteria from #218 are inline above.

## Summary Closes #218. Adds a write-only platform shim for the clipboard so the PAT "Copy" button on `/account` works on native, not just on the PWA. Inline `navigator.clipboard` was wrapped in a Platform-check that no-op'd on Android. ## Shim shape `apps/client/lib/clipboard.ts`: ```ts import * as Clipboard from "expo-clipboard"; import { Platform } from "react-native"; export async function copyToClipboard(text: string): Promise<void> { if (Platform.OS === "web") { await navigator.clipboard.writeText(text); return; } await Clipboard.setStringAsync(text); } ``` - Web (PWA + Tauri webview): `navigator.clipboard.writeText`. - Native: `expo-clipboard`'s `setStringAsync` — bridges to `ClipboardManager.setPrimaryClip` on Android (no manifest permission required, confirmed in upstream docs) and `UIPasteboard` on iOS. ## Call sites swept - `apps/client/app/(app)/account.tsx` — the `RevealBanner` "Copy" button on the PAT plaintext reveal. The plaintext stays on screen as a manual-copy fallback in case `writeText` / `setStringAsync` rejects. `grep -rn "navigator.clipboard"` on `apps/client/` is otherwise clean. ## Dep - `expo-clipboard@~56.0.4` — matches the Expo SDK 56 line (latest dist-tag for the SDK-56 branch). ## Test plan - [x] `pnpm install --frozen-lockfile` - [x] `pnpm -F @carol/client typecheck` / `lint` / `test` / `export:web` - [x] `pnpm -F @carol/api typecheck` / `lint` / `test` - [x] `pnpm -F @carol/api-client typecheck` / `lint` / `test` / `check` - [x] New `tests/clipboard.test.ts` exercises both branches via mocks (`expo-clipboard` mocked on native; `navigator.clipboard` redefined via `Object.defineProperty` on web). - [ ] Manual on Android via Expo Go: mint a PAT, tap Copy, paste into another app — round-trips. (To run before merge; documenting here so the manual gate isn't lost.) - [x] Web (PWA) unchanged — the `Platform.OS === "web"` branch still calls `navigator.clipboard.writeText`, and the export still bundles clean. - [x] No new Android manifest entries (confirmed via upstream docs; `expo-clipboard` doesn't add a permission). ## Acceptance - Acceptance criteria from #218 are inline above.

james added 1 commit 2026-06-23 13:33:42 +00:00

feat(client): native clipboard via expo-clipboard (#218) ... 771cd7d68b

Add a write-only platform shim at apps/client/lib/clipboard.ts —
navigator.clipboard.writeText on web (PWA + Tauri webview),
expo-clipboard's setStringAsync on native. Swap the one inline call
site (the PAT reveal banner on /account) to use it so the Copy button
finally works on Android, not just on the PWA.

- Add expo-clipboard@~56.0.4 (SDK 56 line, no manifest permission
  required per upstream docs).
- New tests/clipboard.test.ts mocks both branches under the existing
  vitest "node" environment.
- README documents the shim and the no-permission stance.

forgejo-actions commented 2026-06-23 13:34:49 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	83.3% ✅	≥ 50%
Branches	75.7% ✅	≥ 75%
Functions	91.9%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 83.3% ✅ | ≥ 50% | | Branches | 75.7% ✅ | ≥ 75% | | Functions | 91.9% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james force-pushed 218-native-clipboard from 771cd7d68b to 55fc1fc583 2026-06-23 15:37:42 +00:00 Compare

james merged commit b479d9c572 into main 2026-06-23 16:05:47 +00:00

james deleted branch 218-native-clipboard 2026-06-23 16:05:47 +00:00

james referenced this pull request from a commit 2026-06-23 16:05:48 +00:00

Merge pull request 'feat(client): native clipboard via expo-clipboard (#218)' (#247) from 218-native-clipboard into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!247

No description provided.