fix(i18n): drop literal <em> tags from empty-state strings #252

Merged

james merged 1 commit from 251-em-tags into main 2026-06-23 16:05:30 +00:00

Conversation 1 Commits 1 Files changed 1 +4 -4

james commented 2026-06-23 15:44:44 +00:00

Owner

Copy link

Summary

Four empty-state strings on Experience (Education / Jobs / Contracts) carried literal <em>...</em> HTML tags that React Native rendered verbatim — users saw the raw tag characters around button names in the empty state.

Replaced the <em> tags with double-quoted emphasis to match the existing catalog convention (Editing "{institution}"… and the delete-confirm prompts already use this shape).

Test plan

• pnpm -F @carol/client test (69 passing)
• grep -E <\w packages/i18n/messages/en.json is empty after the change

Closes #251.

## Summary Four empty-state strings on Experience (Education / Jobs / Contracts) carried literal `<em>...</em>` HTML tags that React Native rendered verbatim — users saw the raw tag characters around button names in the empty state. Replaced the `<em>` tags with double-quoted emphasis to match the existing catalog convention (`Editing "{institution}"…` and the delete-confirm prompts already use this shape). ## Test plan - [x] `pnpm -F @carol/client test` (69 passing) - [x] `grep -E <\w packages/i18n/messages/en.json` is empty after the change Closes #251.

james added 1 commit 2026-06-23 15:44:44 +00:00

fix(i18n): drop literal <em> tags from empty-state strings ... fb820421f1

React Native's <Text> renders the string verbatim — users saw the
literal "<em>" / "</em>" characters around button names in the
Education, Jobs, and Contracts empty-state lines. Replace with
double-quoted emphasis to match the existing catalog convention
("Editing \"{institution}\"…" and the delete-confirm prompts).

Closes #251.

forgejo-actions commented 2026-06-23 15:48:18 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	82.9% ✅	≥ 50%
Branches	75.6% ✅	≥ 75%
Functions	91.8%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 82.9% ✅ | ≥ 50% | | Branches | 75.6% ✅ | ≥ 75% | | Functions | 91.8% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit a4586730d1 into main 2026-06-23 16:05:30 +00:00

james deleted branch 251-em-tags 2026-06-23 16:05:30 +00:00

james referenced this pull request from a commit 2026-06-23 16:05:31 +00:00

Merge pull request 'fix(i18n): drop literal <em> tags from empty-state strings' (#252) from 251-em-tags into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!252

No description provided.