fix(i18n): convert plural templates from ICU to i18next native format #264

Merged

james merged 1 commit from fix-plural-templates into main 2026-06-23 20:56:44 +00:00

Conversation 1 Commits 1 Files changed 1 +4 -2

james commented 2026-06-23 20:55:18 +00:00

Owner

Copy link

Summary

The Jobs screen rendered 0 of {# of positions}} instead of 0 positions — the catalog had ICU MessageFormat plural templates ({count, plural, one {# position} other {# positions}}) but the universal client uses i18next, which doesn't parse ICU MessageFormat without the i18next-icu plugin. So the template body leaked through literal after the leading {count} substitution.

The ICU syntax was inherited from the API side, where next-intl consumed it. These keys are client-only.

Fix

Convert to i18next-native plural format — separate _one / _other keys with regular {count} interpolation:

- "positionsCount": "{count, plural, one {# position} other {# positions}}",
+ "positionsCount_one": "{count} position",
+ "positionsCount_other": "{count} positions",

Same for contributionsCount. i18next picks the right key automatically based on the count argument.

Spanish catalog (es.json) didn't have these keys; falls back to English per ADR-0025.

Test plan

• pnpm -F @carol/client typecheck / test (97 passing).
• jq verifies the four new keys parse and resolve correctly.
• Manual on Android via Expo Go: Jobs screen renders 0 positions / 1 position / N positions correctly.

Future

If more ICU-shaped strings creep into the catalog, consider pulling in i18next-icu to handle them uniformly across both runtimes (API uses next-intl which is ICU-native; client uses i18next which needs the plugin). For now the catalog's only ICU users were these two keys.

## Summary The Jobs screen rendered `0 of {# of positions}}` instead of `0 positions` — the catalog had ICU MessageFormat plural templates (`{count, plural, one {# position} other {# positions}}`) but the universal client uses **i18next**, which doesn't parse ICU MessageFormat without the i18next-icu plugin. So the template body leaked through literal after the leading `{count}` substitution. The ICU syntax was inherited from the API side, where `next-intl` consumed it. These keys are client-only. ## Fix Convert to i18next-native plural format — separate `_one` / `_other` keys with regular `{count}` interpolation: ```diff - "positionsCount": "{count, plural, one {# position} other {# positions}}", + "positionsCount_one": "{count} position", + "positionsCount_other": "{count} positions", ``` Same for `contributionsCount`. i18next picks the right key automatically based on the `count` argument. Spanish catalog (`es.json`) didn't have these keys; falls back to English per ADR-0025. ## Test plan - [x] `pnpm -F @carol/client typecheck` / `test` (97 passing). - [x] `jq` verifies the four new keys parse and resolve correctly. - [ ] Manual on Android via Expo Go: Jobs screen renders `0 positions` / `1 position` / `N positions` correctly. ## Future If more ICU-shaped strings creep into the catalog, consider pulling in `i18next-icu` to handle them uniformly across both runtimes (API uses next-intl which is ICU-native; client uses i18next which needs the plugin). For now the catalog's only ICU users were these two keys.

james added 1 commit 2026-06-23 20:55:18 +00:00

fix(i18n): convert plural templates from ICU to i18next native format ... 9417737091

The catalog had ICU MessageFormat plurals (`{count, plural, one {#
position} other {# positions}}`) authored when the API rendered them
via next-intl. The universal client uses i18next, which doesn't parse
ICU MessageFormat without the i18next-icu plugin — so the literal
template body leaked through to the UI ("0 of {# of positions}}" in
the user-facing wording).

Convert to i18next's native plural format: separate `_one` / `_other`
keys per plural. i18next picks the right key based on `count` and
applies the regular {count} interpolation.

Closes the visible regression on the Jobs screen.

james merged commit 574b4d2cd7 into main 2026-06-23 20:56:44 +00:00

james deleted branch fix-plural-templates 2026-06-23 20:56:44 +00:00

james referenced this pull request from a commit 2026-06-23 20:56:45 +00:00

Merge pull request 'fix(i18n): convert plural templates from ICU to i18next native format' (#264) from fix-plural-templates into main

forgejo-actions commented 2026-06-23 20:59:20 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	82.7% ✅	≥ 50%
Branches	75.1% ✅	≥ 75%
Functions	91.7%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 82.7% ✅ | ≥ 50% | | Branches | 75.1% ✅ | ≥ 75% | | Functions | 91.7% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!264

No description provided.