Show app + server version at the bottom of settings #289
Labels
No labels
area:auth
area:ci
area:db
area:infra
area:native
area:pwa
area:service
epic
feature
foundation
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
james/carol#289
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Embed the build version in the app and surface it at the bottom of the settings (account) screen.
Behaviour
Carol <version>— from the bundle'sexpo.version(read at runtime viaexpo-constants).App <version>(fromexpo-constants) andServer <version>(fromGET /api/healthvia a newuseServerVersionhook in@carol/api-client). ShowsChecking…while loading andUnknownon failure.The underlying defect
The version was a static
0.0.0everywhere:app.jsonexpo.version, rootpackage.json, andapps/api/package.jsonare all0.0.0, and the release workflows parsed the git tag but never wrote it anywhere before building. So/api/healthalways reported0.0.0and the Android build'sversionName/versionCodenever updated per release.Fix: both release workflows now stamp the tag version before building.
release.ymlwrites the tag version intoapps/api/package.json(+ root) beforedocker build, so/api/healthreports the real version.release-android.ymlwritesexpo.version+ a monotonicexpo.android.versionCode(MAJOR*1000000 + MINOR*1000 + PATCH) intoapp.jsonbeforeexpo prebuild, so the APK/AAB carry the realversionName/versionCode.package.json/app.jsonstay at the0.0.0dev placeholder — CI is the only writer.Notes
/api/healthisn't in the generated OpenAPI surface (no zod schema), so the new hook calls it through the typed client with a narrow cast rather than hand-authoring the route into the spec.