feat(client): merge Skills into Experience as a tab; tab order Jobs · Contracts · Education · Skills #311

Closed
opened 2026-06-27 00:44:05 +00:00 by james · 0 comments
Owner

Request

Skills should live under the Experience screen as a tab rather than as its
own top-level nav item. The Experience tab order should be:

  1. Jobs
  2. Contracts
  3. Education
  4. Skills

Changes

  • Extract the Skills screen body into a reusable
    apps/client/lib/experience/SkillsSection.tsx that takes the page-level
    editing flag from Experience (the standalone page chrome — title +
    Edit/Done toggle — is dropped in favour of Experience's).
  • Render it as the new "Skills" tab in app/(app)/experience.tsx, and reorder
    the tabs to Jobs · Contracts · Education · Skills (default tab: Jobs).
  • Remove the /skills sidebar nav item (and its icon binding) and delete the
    app/(app)/skills.tsx route.
  • i18n: add experience.tabs.skills, reorder/refresh experience.lede, drop
    the now-dead nav.skills label. The existing skills.* section copy is
    reused unchanged by the tab.
  • Update navItems.test.ts to the new link set/order.

Out of scope

  • Any change to the Skills data model or API.
  • Persisting the selected Experience tab across navigations.
## Request Skills should live under the **Experience** screen as a tab rather than as its own top-level nav item. The Experience tab order should be: 1. Jobs 2. Contracts 3. Education 4. Skills ## Changes - Extract the Skills screen body into a reusable `apps/client/lib/experience/SkillsSection.tsx` that takes the page-level `editing` flag from Experience (the standalone page chrome — title + Edit/Done toggle — is dropped in favour of Experience's). - Render it as the new "Skills" tab in `app/(app)/experience.tsx`, and reorder the tabs to Jobs · Contracts · Education · Skills (default tab: Jobs). - Remove the `/skills` sidebar nav item (and its icon binding) and delete the `app/(app)/skills.tsx` route. - i18n: add `experience.tabs.skills`, reorder/refresh `experience.lede`, drop the now-dead `nav.skills` label. The existing `skills.*` section copy is reused unchanged by the tab. - Update `navItems.test.ts` to the new link set/order. ## Out of scope - Any change to the Skills data model or API. - Persisting the selected Experience tab across navigations.
james closed this issue 2026-06-27 01:27:24 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
james/carol#311
No description provided.