feat(client): add pull-to-refresh to every content page #314

Merged

james merged 1 commit from 309-pull-to-refresh into main 2026-06-27 01:45:35 +00:00

Conversation 1 Commits 1 Files changed 10 +113 -1

james commented 2026-06-27 00:53:49 +00:00

Owner

Copy link

Adds a shared pull-to-refresh gesture to every server-data page of the universal client, wired to refetch that page's TanStack Query data.

How

New hook lib/nav/useRefreshControl.tsx takes one or more query results and returns a themed <RefreshControl> (accent-colored spinner via useTheme().tokens.accent, i18n accessibilityLabel, web-safe — the control renders but the gesture is native-only). Each page passes it to its scroll container's refreshControl prop.

Page	Container	Query hook(s) refetched
notes	KeyboardAwareScrollView	useNotes
skills	KeyboardAwareScrollView	useSkillSections
projects	KeyboardAwareScrollView	useProjects
profile	KeyboardAwareScrollView	useProfile
experience	KeyboardAwareScrollView	useEducations, useJobs, useContracts
network	KeyboardAwareScrollView	usePeople, useOrganizations
network/[id]	KeyboardAwareScrollView	usePerson, usePeople, useOrganizations
network/orgs/[id]	KeyboardAwareScrollView	useOrganization, usePeople
account	KeyboardAwareScrollView	useMe, useAccountIdentities, useAccountTokens, useServerVersion

applications and chat are Placeholder screens (epics #2/#47) with no scroll container or server query — skipped.

Notes

• Pages whose data spans tabs/cards (experience, network, account) lift the relevant list hooks to the scroll-owning parent so one pull refreshes them all via the shared TanStack cache. Minor behavior change: those lists now fetch on page mount rather than lazily per tab — extra requests are small and keep data fresher.
• Added common.refresh to en.json (sentence case) for the control's accessibility label.

Verification

• pnpm -F @carol/client typecheck — clean
• pnpm -F @carol/client lint — clean
• pnpm -F @carol/client test — 131 pass

Closes #309

🤖 Generated with Claude Code

Adds a shared pull-to-refresh gesture to every server-data page of the universal client, wired to refetch that page's TanStack Query data. ## How New hook `lib/nav/useRefreshControl.tsx` takes one or more query results and returns a themed `<RefreshControl>` (accent-colored spinner via `useTheme().tokens.accent`, i18n `accessibilityLabel`, web-safe — the control renders but the gesture is native-only). Each page passes it to its scroll container's `refreshControl` prop. | Page | Container | Query hook(s) refetched | |---|---|---| | notes | KeyboardAwareScrollView | `useNotes` | | skills | KeyboardAwareScrollView | `useSkillSections` | | projects | KeyboardAwareScrollView | `useProjects` | | profile | KeyboardAwareScrollView | `useProfile` | | experience | KeyboardAwareScrollView | `useEducations`, `useJobs`, `useContracts` | | network | KeyboardAwareScrollView | `usePeople`, `useOrganizations` | | network/[id] | KeyboardAwareScrollView | `usePerson`, `usePeople`, `useOrganizations` | | network/orgs/[id] | KeyboardAwareScrollView | `useOrganization`, `usePeople` | | account | KeyboardAwareScrollView | `useMe`, `useAccountIdentities`, `useAccountTokens`, `useServerVersion` | `applications` and `chat` are Placeholder screens (epics #2/#47) with no scroll container or server query — skipped. ## Notes - Pages whose data spans tabs/cards (experience, network, account) lift the relevant list hooks to the scroll-owning parent so one pull refreshes them all via the shared TanStack cache. Minor behavior change: those lists now fetch on page mount rather than lazily per tab — extra requests are small and keep data fresher. - Added `common.refresh` to `en.json` (sentence case) for the control's accessibility label. ## Verification - `pnpm -F @carol/client typecheck` — clean - `pnpm -F @carol/client lint` — clean - `pnpm -F @carol/client test` — 131 pass Closes #309 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james added 1 commit 2026-06-27 00:53:49 +00:00

feat(client): add pull-to-refresh to every content page ... a1d2bdb520

Add a shared pull-to-refresh gesture to every server-data page of the
universal client, wired to refetch that page's TanStack Query data.

New hook lib/nav/useRefreshControl.tsx takes one or more query results
and returns a themed <RefreshControl> (accent-colored spinner, i18n
accessibility label, web-safe). Wired into notes, skills, projects,
profile, experience, network (list + person + org detail), and account.
Pages whose data spans tabs/cards (experience, network, account) lift the
relevant list hooks to the scroll-owning parent so one pull refreshes all
of them via the shared TanStack cache.

Placeholder screens (applications, chat) have no server query and are
skipped. Added common.refresh to the en.json catalog for the control's
accessibility label.

Closes #309

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

forgejo-actions commented 2026-06-27 00:58:37 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	81.6% ✅	≥ 50%
Branches	72.8% ⚠️	≥ 75%
Functions	91.1%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 81.6% ✅ | ≥ 50% | | Branches | 72.8% ⚠️ | ≥ 75% | | Functions | 91.1% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james force-pushed 309-pull-to-refresh from a1d2bdb520 to 57965318b3 2026-06-27 01:40:32 +00:00 Compare

james merged commit 377391c9a8 into main 2026-06-27 01:45:35 +00:00

james deleted branch 309-pull-to-refresh 2026-06-27 01:45:36 +00:00

james referenced this pull request from a commit 2026-06-27 01:45:37 +00:00

Merge pull request 'feat(client): add pull-to-refresh to every content page' (#314) from 309-pull-to-refresh into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!314

No description provided.