feat(api): link a Job/Contract's employer to a network Organization (#375) #376

Merged

james merged 1 commit from 375-job-org-link-backend into main 2026-06-29 16:34:08 +00:00

Conversation 1 Commits 1 Files changed 21 +872 -40

james commented 2026-06-29 16:23:16 +00:00

Owner

Copy link

Backend for #375 — tie a company you've worked at to a tracked network Organization, mirroring the people↔organizations link-or-stub pattern. A job is 1:1 with an employer, so it's a nullable FK column on jobs, not a junction. The client UI (link picker + "your roles here") is a tracked follow-up.

What's in it

• Migration 026: jobs.organization_id nullable FK → organizations(id) ON DELETE SET NULL. Existing jobs stay unlinked free-text — no backfill.
• Live name on read: linked jobs resolve the org's current name via LEFT JOIN organizations (JobWithOrg → DTO organizationName); rename the org → the job reflects it. company is kept as a fallback snapshot, refreshed to the org name at link time.
• Org delete = copy-down (OrganizationsRepository.deleteById): snapshot the org name into linked jobs' company + null the link before deleting the org, so career history degrades to a stub with no data loss. The FK SET NULL is the Postgres safety net; the app-level copy-down is the real mechanism (SQLite FK enforcement is off) and runs on both engines — two plain statements (no transaction, mirroring conversations.delete for the libsql :memory: leg).
• Link validation (lib/api/job-organization-link.ts): a cross-user/missing org id → 404 (don't leak existence); applies to both jobs and contracts. On a valid link, company is set to the org's name (fresh snapshot).
• Reverse view: GET /api/organizations/{id}/roles lists the linked jobs/roles.
• zod/openapi + api-client regenerated (coverage 121 → 122); idea.md updated.

Verification (I re-ran all of it, incl. the Postgres leg)

• test against both engines (ephemeral Postgres): 1257 passed, 0 skipped — the migration applies on Postgres and the new dual-engine tests cover link, unlink, live-name-on-rename, org-delete copy-down, listByOrganizationId scoping, cross-user 404, and contract linking.
• typecheck ✓ · lint ✓ · openapi:check ✓ / coverage 122 · @carol/api-client check ✓ · semgrep ✓ 0 findings on the new files.

Follow-up (rest of #375)

• Client: Job create/edit company field that picks an Organization or stays free text; tap-company → Org detail; the org detail's "your roles here" section (consumes /roles).
• An agent link_job_to_org tool (mirroring link_person_to_org).

Part of #375.

🤖 Generated with Claude Code

Backend for #375 — tie a company you've worked at to a tracked network Organization, mirroring the people↔organizations link-or-stub pattern. A job is 1:1 with an employer, so it's a nullable FK column on `jobs`, not a junction. **The client UI (link picker + "your roles here") is a tracked follow-up.** ## What's in it - **Migration 026:** `jobs.organization_id` nullable FK → `organizations(id)` `ON DELETE SET NULL`. Existing jobs stay unlinked free-text — no backfill. - **Live name on read:** linked jobs resolve the org's current name via `LEFT JOIN organizations` (`JobWithOrg` → DTO `organizationName`); rename the org → the job reflects it. `company` is kept as a fallback snapshot, refreshed to the org name at link time. - **Org delete = copy-down** (`OrganizationsRepository.deleteById`): snapshot the org name into linked jobs' `company` + null the link *before* deleting the org, so career history degrades to a stub with no data loss. The FK `SET NULL` is the Postgres safety net; the app-level copy-down is the real mechanism (SQLite FK enforcement is off) and runs on both engines — two plain statements (no transaction, mirroring `conversations.delete` for the libsql `:memory:` leg). - **Link validation** (`lib/api/job-organization-link.ts`): a cross-user/missing org id → **404** (don't leak existence); applies to both jobs and contracts. On a valid link, `company` is set to the org's name (fresh snapshot). - **Reverse view:** `GET /api/organizations/{id}/roles` lists the linked jobs/roles. - zod/openapi + api-client regenerated (coverage 121 → **122**); `idea.md` updated. ## Verification (I re-ran all of it, incl. the Postgres leg) - `test` against **both engines** (ephemeral Postgres): **1257 passed, 0 skipped** — the migration applies on Postgres and the new dual-engine tests cover link, unlink, **live-name-on-rename**, **org-delete copy-down**, `listByOrganizationId` scoping, **cross-user 404**, and contract linking. - `typecheck` ✓ · `lint` ✓ · `openapi:check` ✓ / coverage 122 · `@carol/api-client check` ✓ · semgrep ✓ 0 findings on the new files. ## Follow-up (rest of #375) - Client: Job create/edit company field that picks an Organization or stays free text; tap-company → Org detail; the org detail's "your roles here" section (consumes `/roles`). - An agent `link_job_to_org` tool (mirroring `link_person_to_org`). Part of #375. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james added 1 commit 2026-06-29 16:23:17 +00:00

feat(api): link a Job/Contract's employer to a network Organization (#375) ... 9f79621dcf

Backend for tying a company you've worked at to a tracked Organization,
mirroring the people↔organizations link-or-stub pattern. A job is 1:1
with an employer, so it's a nullable FK column on jobs, not a junction.

- Migration 026: jobs.organization_id nullable FK → organizations(id)
  ON DELETE SET NULL. Existing jobs stay unlinked free-text — no backfill.
- Linked jobs resolve the org's LIVE name on read (LEFT JOIN organizations
  → JobWithOrg / DTO organizationName); company is kept as a fallback
  snapshot, refreshed to the org's name at link time.
- Org delete = copy-down (OrganizationsRepository.deleteById): snapshot
  the org name into linked jobs' company + null the link before deleting,
  so career history degrades to a stub with no data loss. FK SET NULL is
  the Postgres safety net; the app-level copy-down is the real mechanism
  (SQLite FK enforcement is off), runs on both engines.
- Link validation (lib/api/job-organization-link.ts): a cross-user/missing
  org id → 404 (don't leak existence); applies to both jobs and contracts.
- Reverse view: GET /api/organizations/{id}/roles lists the linked
  jobs/roles (for the org detail's "your roles here").
- zod/openapi + api-client regenerated (coverage 121 → 122); idea.md
  updated.

Dual-engine tests: link, unlink, live-name-on-rename, org-delete copy-down,
listByOrganizationId scoping, cross-user 404, contract linking.

Part of #375 (client UI — link picker + "roles here" — is a follow-up).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

forgejo-actions commented 2026-06-29 16:28:43 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	79.5% ✅	≥ 50%
Branches	71.5% ⚠️	≥ 75%
Functions	80.6%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 79.5% ✅ | ≥ 50% | | Branches | 71.5% ⚠️ | ≥ 75% | | Functions | 80.6% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit 25fe865651 into main 2026-06-29 16:34:08 +00:00

james deleted branch 375-job-org-link-backend 2026-06-29 16:34:08 +00:00

james referenced this pull request from a commit 2026-06-29 16:34:09 +00:00

Merge pull request 'feat(api): link a Job/Contract's employer to a network Organization (#375)' (#376) from 375-job-org-link-backend into main

james referenced this pull request from a commit 2026-06-29 16:48:32 +00:00

feat(client): link a Job/Contract employer to an Organization in the UI (#375)

james referenced this pull request 2026-06-29 16:48:48 +00:00

feat(client): link a Job/Contract employer to an Organization in the UI (#375) #378

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!376

No description provided.