feat(client): readable diffs in the proposal + activity cards #363

New issue

Closed

opened 2026-06-29 13:19:11 +00:00 by james · 0 comments

james commented

2026-06-29 13:19:11 +00:00

Owner

The chat confirmation card (#346) and the activity undo card (#356) render a proposed change's diff as raw pretty-printed JSON (renderDiff). Replace that with a readable, human field-level diff.

Scope

A shared diff renderer that understands the ProposedChange.diff shapes (per ADR-0030: create → { after }; update → { fields: { k: { old, new } } }; delete → { before }; merge → both sources + survivor) and renders them as labeled before→after rows rather than a JSON blob.
Use it in both the chat ProposalCard and the activity confirmation card (extract the shared component while we're at it — they currently duplicate renderDiff + destructive styling).
DS tokens + Carol's voice; entity/field names localized where practical (or humanized fallback like the activity entity nouns).
Pure render-logic where possible so it's node-testable; visual polish verified by the maintainer.

Out of scope

Rich semantic diffs of long text bodies (a simple old→new is fine for v1).

Part of epic #47 (polish on the write-confirmation surface).

The chat confirmation card (#346) and the activity undo card (#356) render a proposed change's `diff` as raw pretty-printed JSON (`renderDiff`). Replace that with a readable, human field-level diff. ## Scope - A shared diff renderer that understands the `ProposedChange.diff` shapes (per ADR-0030: create → `{ after }`; update → `{ fields: { k: { old, new } } }`; delete → `{ before }`; merge → both sources + survivor) and renders them as labeled before→after rows rather than a JSON blob. - Use it in both the chat `ProposalCard` and the activity confirmation card (extract the shared component while we're at it — they currently duplicate `renderDiff` + destructive styling). - DS tokens + Carol's voice; entity/field names localized where practical (or humanized fallback like the activity entity nouns). - Pure render-logic where possible so it's node-testable; visual polish verified by the maintainer. ## Out of scope - Rich semantic diffs of long text bodies (a simple old→new is fine for v1). Part of epic #47 (polish on the write-confirmation surface).

james referenced this issue

2026-06-29 13:39:02 +00:00

feat(api): rename + delete conversation endpoints (#364) #366

james referenced this issue from a commit

2026-06-29 13:40:25 +00:00

feat(client): render proposal diffs as readable field-level changes (#363)

james referenced this issue from a pull request that will close it,

2026-06-29 13:40:37 +00:00

feat(client): render proposal diffs as readable field-level changes (#363) #367

james closed this issue

2026-06-29 13:51:36 +00:00

james referenced this issue from a commit