feat(client): use the shared ProposalDiff in the activity undo card (#363 follow-up) #370

Merged

james merged 1 commit from 363-followup-activity-diff into main 2026-06-29 14:16:59 +00:00

Conversation 1 Commits 1 Files changed 1 +2 -36

james commented 2026-06-29 14:08:41 +00:00

Owner

Copy link

Completes the "both places" intent of #363. That PR extracted a shared <ProposalDiff> and wired it into the chat confirmation card — but the activity undo card (#356/#357) wasn't merged on #363's base, so it still rendered its diff as raw pretty-printed JSON.

Now that both are in:

• The activity undo card uses <ProposalDiff diff={pending.diff} action={pending.action} />.
• Removed the now-redundant local renderDiff helper, the local DESTRUCTIVE_ACTIONS set, and the unused styles.diff — DESTRUCTIVE_ACTIONS is imported from the shared module too.

So the undo confirmation now shows the same readable field-level diff (old → new rows, destructive tinting) as the chat card.

Verification (local)

• typecheck ✓ · lint ✓ · test ✓ 172 · semgrep ✓ 0 findings

Net diff is small (one screen). Visual parity with the chat card is worth a glance, but the shared component is already tested.

🤖 Generated with Claude Code

Completes the "both places" intent of #363. That PR extracted a shared `<ProposalDiff>` and wired it into the **chat** confirmation card — but the **activity** undo card (#356/#357) wasn't merged on #363's base, so it still rendered its diff as raw pretty-printed JSON. Now that both are in: - The activity undo card uses `<ProposalDiff diff={pending.diff} action={pending.action} />`. - Removed the now-redundant local `renderDiff` helper, the local `DESTRUCTIVE_ACTIONS` set, and the unused `styles.diff` — `DESTRUCTIVE_ACTIONS` is imported from the shared module too. So the undo confirmation now shows the same readable field-level diff (old → new rows, destructive tinting) as the chat card. ## Verification (local) - `typecheck` ✓ · `lint` ✓ · `test` ✓ 172 · semgrep ✓ 0 findings Net diff is small (one screen). Visual parity with the chat card is worth a glance, but the shared component is already tested. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james added 1 commit 2026-06-29 14:08:41 +00:00

feat(client): use the shared ProposalDiff in the activity undo card (#363 follow-up) ... e0f676df2d

#363 extracted a shared <ProposalDiff> and wired it into the chat
confirmation card, but the activity undo card (#356/#357) wasn't merged
on its base, so it still rendered its diff as raw JSON. Now that both are
in, swap the activity card's local renderDiff for <ProposalDiff>, and drop
the now-redundant renderDiff helper, local DESTRUCTIVE_ACTIONS set, and
styles.diff (both imported from the shared module). Completes the "both
places" intent of #363.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

forgejo-actions commented 2026-06-29 14:14:23 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	79.4% ✅	≥ 50%
Branches	71.2% ⚠️	≥ 75%
Functions	80.5%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 79.4% ✅ | ≥ 50% | | Branches | 71.2% ⚠️ | ≥ 75% | | Functions | 80.5% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit 25376ff02c into main 2026-06-29 14:16:59 +00:00

james deleted branch 363-followup-activity-diff 2026-06-29 14:16:59 +00:00

james referenced this pull request from a commit 2026-06-29 14:17:00 +00:00

Merge pull request 'feat(client): use the shared ProposalDiff in the activity undo card (#363 follow-up)' (#370) from 363-followup-activity-diff into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!370

No description provided.