feat(api): rename + delete conversation endpoints (#364) #366

Merged

james merged 1 commit from 364-chat-conversation-mgmt into main 2026-06-29 13:51:18 +00:00

Conversation 1 Commits 1 Files changed 10 +544 -8

james commented 2026-06-29 13:39:02 +00:00

Owner

Copy link

The data layer for chat conversation management (#364). The switcher needs to rename and delete conversations, but only GET existed. This adds the endpoints + hooks; the chat switcher UI is a follow-up — deliberately sequenced after the in-flight chat.tsx changes (#352 markdown, #363 diffs) settle, to avoid a three-way merge pileup on that file.

What's in it

• ConversationsRepository.updateTitle(id, title) and delete(id). delete clears messages then the conversation as two plain statements — FK enforcement isn't on for the SQLite leg, and a transaction would run against libsql's per-connection :memory: test DB (schemaless); messages-first self-heals on a mid-failure.
• PATCH /api/conversations/{id} (rename, zUpdateConversationRequest; empty title clears it) and DELETE /api/conversations/{id} (200 { ok }). Per-user 404; a cross-user rename/delete can't touch another user's conversation.
• @carol/api-client: useUpdateConversation + useDeleteConversation.
• zod/openapi + api-client types regenerated (coverage 119 → 121).

Verification (local)

• typecheck ✓ · lint ✓
• test against both engines (ephemeral Postgres): 1238 passed, 0 skipped (+ dual-engine repo tests: rename, delete-cascades-messages; route tests: rename/clear, delete→404, cross-user 404, 401)
• @carol/api-client: check ✓ · test ✓ 42 · openapi:check ✓ · coverage 121
• semgrep ✓ 0 findings on the new files

Follow-up (the rest of #364)

• The chat switcher UI: rename (inline edit) + delete (confirm) + search/filter + auto-scroll-to-latest. Will land on top of the settled chat.tsx once #352/#363 merge.

Part of #364.

🤖 Generated with Claude Code

The data layer for chat conversation management (#364). The switcher needs to rename and delete conversations, but only GET existed. This adds the endpoints + hooks; **the chat switcher UI is a follow-up** — deliberately sequenced after the in-flight `chat.tsx` changes (#352 markdown, #363 diffs) settle, to avoid a three-way merge pileup on that file. ## What's in it - **`ConversationsRepository.updateTitle(id, title)`** and **`delete(id)`**. `delete` clears messages then the conversation as two plain statements — FK enforcement isn't on for the SQLite leg, and a transaction would run against libsql's per-connection `:memory:` test DB (schemaless); messages-first self-heals on a mid-failure. - **`PATCH /api/conversations/{id}`** (rename, `zUpdateConversationRequest`; empty title clears it) and **`DELETE /api/conversations/{id}`** (`200 { ok }`). Per-user 404; a cross-user rename/delete can't touch another user's conversation. - **`@carol/api-client`**: `useUpdateConversation` + `useDeleteConversation`. - zod/openapi + api-client types regenerated (coverage 119 → 121). ## Verification (local) - `typecheck` ✓ · `lint` ✓ - `test` against **both engines** (ephemeral Postgres): **1238 passed, 0 skipped** (+ dual-engine repo tests: rename, delete-cascades-messages; route tests: rename/clear, delete→404, cross-user 404, 401) - `@carol/api-client`: `check` ✓ · test ✓ 42 · `openapi:check` ✓ · coverage 121 - semgrep ✓ 0 findings on the new files ## Follow-up (the rest of #364) - The chat switcher UI: rename (inline edit) + delete (confirm) + search/filter + auto-scroll-to-latest. Will land on top of the settled `chat.tsx` once #352/#363 merge. Part of #364. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james added 1 commit 2026-06-29 13:39:03 +00:00

feat(api): rename + delete conversation endpoints (#364) ... 24778900d3

The chat conversation switcher needs to rename and delete conversations;
only GET existed. Add the data layer + hooks (the chat UI is a follow-up,
sequenced after the in-flight chat.tsx changes settle).

- ConversationsRepository.updateTitle(id, title) and delete(id). delete
  clears messages then the conversation as two plain statements — FK
  enforcement isn't on for the SQLite leg, and a transaction would run
  against libsql's per-connection :memory: DB; messages-first self-heals.
- PATCH /api/conversations/{id} (rename, zUpdateConversationRequest) and
  DELETE /api/conversations/{id} (200 {ok}). Per-user 404; cross-user
  rename/delete can't touch another user's conversation.
- @carol/api-client: useUpdateConversation + useDeleteConversation.
- zod/openapi + api-client types regenerated (coverage 119 → 121).

Dual-engine repo tests (rename, delete-cascades-messages) + route tests
(rename/clear, delete→404, cross-user 404, 401).

Part of #364.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

james referenced this pull request 2026-06-29 13:41:54 +00:00

chore(api): register MessageDto as a named OpenAPI component (#365) #368

forgejo-actions commented 2026-06-29 13:44:27 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	79.4% ✅	≥ 50%
Branches	71.2% ⚠️	≥ 75%
Functions	80.5%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 79.4% ✅ | ≥ 50% | | Branches | 71.2% ⚠️ | ≥ 75% | | Functions | 80.5% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit f1bd3542e0 into main 2026-06-29 13:51:18 +00:00

james deleted branch 364-chat-conversation-mgmt 2026-06-29 13:51:18 +00:00

james referenced this pull request from a commit 2026-06-29 13:51:19 +00:00

Merge pull request 'feat(api): rename + delete conversation endpoints (#364)' (#366) from 364-chat-conversation-mgmt into main

james referenced this pull request from a commit 2026-06-29 14:03:26 +00:00

feat(client): chat conversation management — rename, delete, search, auto-scroll (#364)

james referenced this pull request 2026-06-29 14:03:43 +00:00

feat(client): chat conversation management — rename, delete, search, auto-scroll (#364) #369

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!366

No description provided.