feat(client): probe /api/health on server-setup save (#236) #382

Merged

james merged 1 commit from 236-health-probe into main 2026-06-29 18:11:33 +00:00

Conversation 1 Commits 1 Files changed 4 +208 -8

james commented 2026-06-29 17:55:07 +00:00

Owner

Copy link

Closes #236

The server-setup screen only checked that the URL was syntactically http(s). A wrong address surfaced later as a confusing login failure. Now, after the syntactic check and before saving, the screen probes the server and confirms it actually looks like Carol.

What changed

• lib/serverUrlProbe.ts (new): pure helper with injectable fetch. GETs <url>/api/health with a 5s AbortSignal.timeout. Success = HTTP 200 and a JSON body carrying string status + version (HealthDto's signature). A throw/abort → unreachable; a non-200 or wrong-shaped body → notCarol.
• app/server-setup.tsx: probe runs between the syntactic check and the save; inline ActivityIndicator spinner + disabled submit while probing; distinct error copy per failure reason.
• i18n: serverSetup.errors.unreachable / serverSetup.errors.notCarol in Carol's voice (verified they resolve relative to the screen's namespace).
• Unit tests (9): happy path, network throw, AbortError, timeout, 404, 503, wrong body, unparseable JSON.

Verification

• typecheck / lint clean, 181 tests pass, semgrep 0, en.json valid.
• Not verifiable headlessly: the submit spinner + navigation-on-success need a device/browser visual check (client vitest is node-env, no RN render).

Merge note

Overlaps #239 on apps/client/app/server-setup.tsx (this PR changes its logic; #239 scrubs its style arrays). Merge this first; #239 rebases cleanly on top.

🤖 Generated with Claude Code

Closes #236 The server-setup screen only checked that the URL was syntactically `http(s)`. A wrong address surfaced later as a confusing login failure. Now, after the syntactic check and before saving, the screen probes the server and confirms it actually looks like Carol. ## What changed - **`lib/serverUrlProbe.ts`** (new): pure helper with injectable `fetch`. GETs `<url>/api/health` with a 5s `AbortSignal.timeout`. Success = HTTP 200 **and** a JSON body carrying string `status` + `version` (HealthDto's signature). A throw/abort → `unreachable`; a non-200 or wrong-shaped body → `notCarol`. - **`app/server-setup.tsx`**: probe runs between the syntactic check and the save; inline `ActivityIndicator` spinner + disabled submit while probing; distinct error copy per failure reason. - **i18n**: `serverSetup.errors.unreachable` / `serverSetup.errors.notCarol` in Carol's voice (verified they resolve relative to the screen's namespace). - **Unit tests** (9): happy path, network throw, AbortError, timeout, 404, 503, wrong body, unparseable JSON. ## Verification - typecheck / lint clean, 181 tests pass, semgrep 0, en.json valid. - **Not verifiable headlessly**: the submit spinner + navigation-on-success need a device/browser visual check (client vitest is node-env, no RN render). ## Merge note Overlaps **#239** on `apps/client/app/server-setup.tsx` (this PR changes its logic; #239 scrubs its style arrays). Merge this first; #239 rebases cleanly on top. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james added 1 commit 2026-06-29 17:55:08 +00:00

feat(client): probe /api/health on server-setup save (#236) ... df4fbc9625

The server-setup screen only validated the URL was syntactically
http(s); a wrong address surfaced later as a confusing login error.
After the syntactic check and before saving, probe the server.

- lib/serverUrlProbe.ts: pure, injectable-fetch helper. GET <url>/api/health
  with a 5s AbortSignal.timeout; success = 200 + a body carrying string
  `status` + `version` (HealthDto's signature). A throw/abort → unreachable;
  non-200 or wrong body → notCarol.
- server-setup.tsx: probe between the syntactic check and the save;
  inline spinner + disabled submit while probing; distinct error copy.
- i18n: serverSetup.errors.{unreachable,notCarol} (Carol's voice).
- Unit tests: happy path + network-throw + abort/timeout + non-200 +
  wrong/unparseable body.

Closes #236

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

james referenced this pull request 2026-06-29 17:55:36 +00:00

chore(client): scrub style={[...]} on DOM-leaf primitives + ESLint guardrail (#239) #384

forgejo-actions commented 2026-06-29 18:00:41 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	79.6% ✅	≥ 50%
Branches	71.5% ⚠️	≥ 75%
Functions	80.8%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 79.6% ✅ | ≥ 50% | | Branches | 71.5% ⚠️ | ≥ 75% | | Functions | 80.8% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit 0e11d37177 into main 2026-06-29 18:11:33 +00:00

james deleted branch 236-health-probe 2026-06-29 18:11:33 +00:00

james referenced this pull request from a commit 2026-06-29 18:11:35 +00:00

Merge pull request 'feat(client): probe /api/health on server-setup save (#236)' (#382) from 236-health-probe into main

james referenced this pull request 2026-06-30 12:04:54 +00:00

Visual spot-check: server-setup probe flow + style-array scrub (#236/#239 follow-up) #389

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!382

No description provided.