Visual spot-check: server-setup probe flow + style-array scrub (#236/#239 follow-up) #389

New issue

Open

opened 2026-06-30 12:04:54 +00:00 by james · 0 comments

james commented

2026-06-30 12:04:54 +00:00

Owner

Follow-up to #236 (PR #382) and #239 (PR #384), both merged. Both shipped with green headless gates (typecheck/lint/test/export:web), but the client vitest runner is node-env with no RN render, so anything visual or layout-related is unverified. These need a quick human spot-check on the web build (and ideally Android).

What to check

From #236 — server-setup health probe

The submit button shows the inline ActivityIndicator spinner and is disabled while the probe runs.
A reachable Carol URL → saves and navigates onward.
An unreachable URL → the serverSetup.errors.unreachable copy renders.
A reachable non-Carol URL → the serverSetup.errors.notCarol copy renders.

From #239 — `style={[...]}` → merged-object scrub (613 sites)

The scrub was style-shape-only (no intended visual change), but it touched 16 files. Spot-check the heaviest screens render correctly with no layout/spacing/color regressions:

account.tsx (162 sites), experience.tsx (155), chat.tsx (49), SkillsSection.tsx (42), network/[id].tsx (38), network/orgs/[id].tsx (30).
Pay attention to conditional styles (pressed/disabled/active states) and the ...(textStyle)-style variable spreads flagged in PR #384 — confirm a single style object renders as before.

Notes

No code change expected; this is a verification pass. Close once eyeballed, or open a fix ticket if a regression surfaces.

Follow-up to #236 (PR #382) and #239 (PR #384), both merged. Both shipped with green headless gates (typecheck/lint/test/`export:web`), but the client vitest runner is **node-env with no RN render**, so anything visual or layout-related is unverified. These need a quick human spot-check on the web build (and ideally Android). ## What to check ### From #236 — server-setup health probe - The submit button shows the inline `ActivityIndicator` spinner and is disabled while the probe runs. - A reachable Carol URL → saves and navigates onward. - An unreachable URL → the `serverSetup.errors.unreachable` copy renders. - A reachable non-Carol URL → the `serverSetup.errors.notCarol` copy renders. ### From #239 — `style={[...]}` → merged-object scrub (613 sites) The scrub was style-shape-only (no intended visual change), but it touched 16 files. Spot-check the heaviest screens render correctly with no layout/spacing/color regressions: - `account.tsx` (162 sites), `experience.tsx` (155), `chat.tsx` (49), `SkillsSection.tsx` (42), `network/[id].tsx` (38), `network/orgs/[id].tsx` (30). - Pay attention to conditional styles (pressed/disabled/active states) and the `...(textStyle)`-style variable spreads flagged in PR #384 — confirm a single style object renders as before. ## Notes - No code change expected; this is a verification pass. Close once eyeballed, or open a fix ticket if a regression surfaces.