feat(i18n): adopt next-intl + migrate every visible string (#146) #153

Merged

james merged 2 commits from 146-i18n into main 2026-06-20 01:00:43 +00:00

Conversation 2 Commits 2 Files changed 35 +1999 -458

james commented 2026-06-19 22:39:59 +00:00

Owner

Copy link

Closes #146.

Summary

• Adopt next-intl with single-locale-per-request resolution
  (?locale= → carol_locale cookie → Accept-Language →
  DEFAULT_LOCALE) — logic in lib/i18n/locales.ts, wired through
  lib/i18n/request.ts.
• messages/en.json is the source-of-truth catalog. Sibling locales
  may be partial — missing keys silently fall back to English per-key.
  A smoke messages/es.json ships covering home, nav, and login.
• Every visible string in app/(app)/, /login, /register, the
  home page, and shared components routes through useTranslations()
  (client) or getTranslations() (server).
• Locale picker: server wrapper (locale-picker-server.tsx) renders
  null when SUPPORTED_LOCALES has one entry; client island writes
  the cookie via a server action and revalidatePath("/", "layout").
• Exceptions documented in ADR-0025: /offline stays English-only
  (force-static can't read cookies); zod schema messages deferred to
  a follow-up.
• DEFAULT_LOCALE + SUPPORTED_LOCALES added to README Operations
  table. CLAUDE.md Conventions gains the no-hardcoded-strings rule.
  ADR-0025 captures the library choice, resolution chain, and partial-
  catalog policy.

Test plan

• npx tsc --noEmit clean
• npm run lint clean
• npx vitest run — 440 passed / 91 skipped, including 19 new
  tests in tests/i18n/resolve.test.ts covering the resolution
  chain (fallback, header negotiation, region-strip, env parsing)
• npm run build succeeds
• Hit /?locale=es with SUPPORTED_LOCALES=en,es → home page
  renders Spanish strings, falls back to English for unmigrated
  surfaces
• Sign in with the locale picker visible → switching writes the
  carol_locale cookie and the new locale persists across pages
• Accept-Language: es,en;q=0.5 with no cookie → home renders
  Spanish

Closes #146. ## Summary - Adopt `next-intl` with single-locale-per-request resolution (`?locale=` → `carol_locale` cookie → `Accept-Language` → `DEFAULT_LOCALE`) — logic in `lib/i18n/locales.ts`, wired through `lib/i18n/request.ts`. - `messages/en.json` is the source-of-truth catalog. Sibling locales may be partial — missing keys silently fall back to English per-key. A smoke `messages/es.json` ships covering `home`, `nav`, and `login`. - Every visible string in `app/(app)/`, `/login`, `/register`, the home page, and shared components routes through `useTranslations()` (client) or `getTranslations()` (server). - Locale picker: server wrapper (`locale-picker-server.tsx`) renders `null` when `SUPPORTED_LOCALES` has one entry; client island writes the cookie via a server action and `revalidatePath("/", "layout")`. - Exceptions documented in ADR-0025: `/offline` stays English-only (force-static can't read cookies); zod schema messages deferred to a follow-up. - `DEFAULT_LOCALE` + `SUPPORTED_LOCALES` added to README Operations table. CLAUDE.md Conventions gains the no-hardcoded-strings rule. ADR-0025 captures the library choice, resolution chain, and partial- catalog policy. ## Test plan - [x] `npx tsc --noEmit` clean - [x] `npm run lint` clean - [x] `npx vitest run` — 440 passed / 91 skipped, including 19 new tests in `tests/i18n/resolve.test.ts` covering the resolution chain (fallback, header negotiation, region-strip, env parsing) - [x] `npm run build` succeeds - [ ] Hit `/?locale=es` with `SUPPORTED_LOCALES=en,es` → home page renders Spanish strings, falls back to English for unmigrated surfaces - [ ] Sign in with the locale picker visible → switching writes the `carol_locale` cookie and the new locale persists across pages - [ ] `Accept-Language: es,en;q=0.5` with no cookie → home renders Spanish

james added 1 commit 2026-06-19 22:39:59 +00:00

feat(i18n): adopt next-intl + migrate every visible string (#146) ... c40623afa3

next-intl with single-locale-per-request resolution
(?locale → cookie → Accept-Language → DEFAULT_LOCALE) wired through
a tiny lib/i18n module. messages/en.json is the source-of-truth
catalog; sibling locales may be partial and silently fall back to
English per-key. A smoke messages/es.json covers home + login + nav.

Every visible string in app/(app)/, /login, /register, the home
page, and shared components flows through useTranslations() /
getTranslations(). The locale picker is a server/client split that
writes the carol_locale cookie via a server action and renders
nothing when SUPPORTED_LOCALES has one entry.

DEFAULT_LOCALE + SUPPORTED_LOCALES added to README Operations
table; CLAUDE.md Conventions gains a no-hardcoded-strings rule;
ADR-0023 captures the library choice, resolution chain, partial-
catalog policy, and the deferred zod-schema-message follow-up.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

forgejo-actions commented 2026-06-19 22:43:02 +00:00

Copy link

Trivy (container image)

Threshold: high  ·  Total findings: 121  ·  At/above threshold: 1

critical	high	medium	low
0	1	50	70

severity	id	package	installed / range	fix
high	CVE-2026-12151	undici	6.25.0	6.27.0, 7.28.0, 8.5.0

<!-- scanner-comment: trivy --> ### Trivy (container image) **Threshold:** `high` &nbsp;·&nbsp; **Total findings:** 121 &nbsp;·&nbsp; **At/above threshold:** 1 | critical | high | medium | low | |---:|---:|---:|---:| | 0 | 1 | 50 | 70 | | severity | id | package | installed / range | fix | |---|---|---|---|---| | high | [CVE-2026-12151](https://avd.aquasec.com/nvd/cve-2026-12151) | undici | 6.25.0 | `6.27.0, 7.28.0, 8.5.0` |

james added 1 commit 2026-06-19 23:06:20 +00:00

build: regenerate lockfile under npm 10 to add @swc/helpers peer dep ... 1aec3342ba

npm 11 (Node 26 locally) and npm 10 (Node 22 in CI) treat optional
peer deps differently in lockfiles. npm 11 deduped `@swc/helpers`
to the top-level 0.5.15, npm 10 expects `@swc/helpers@0.5.23` (the
peer-satisfying version under next-intl's nested @swc/core) to be
present and fails `npm ci` with EUSAGE.

Regenerating with `npx npm@10 install --package-lock-only` adds
that nested entry. Other diffs are libc-field normalization
between the two npm versions.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

forgejo-actions commented 2026-06-19 23:08:56 +00:00

Copy link

📊 Test coverage

Patch coverage: 37.4% (49/131 added lines) ⚠️ (soft target ≥ 80%)

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	85.5% ✅	≥ 50%
Branches	81.2% ✅	≥ 75%
Functions	90.0%	informational

Changed files in this PR (source only — tests excluded):

File	Patch coverage	Overall lines	Branches
app/(app)/components/placeholder.tsx	0.0% (0/8)	0.0%	0.0%
app/(app)/components/top-nav.tsx	0.0% (0/12)	0.0%	0.0%
lib/dto/auth.ts	0.0% (0/10)	0.0%	0.0%
lib/i18n/locales.ts	92.5% (49/53)	92.5%	94.3%
lib/i18n/request.ts	0.0% (0/31)	0.0%	0.0%
lib/i18n/set-locale-action.ts	0.0% (0/17)	0.0%	0.0%

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** 37.4% (49/131 added lines) ⚠️ *(soft target ≥ 80%)* **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 85.5% ✅ | ≥ 50% | | Branches | 81.2% ✅ | ≥ 75% | | Functions | 90.0% | informational | **Changed files in this PR** (source only — tests excluded): | File | Patch coverage | Overall lines | Branches | |---|---|---|---| | `app/(app)/components/placeholder.tsx` | 0.0% (0/8) | 0.0% | 0.0% | | `app/(app)/components/top-nav.tsx` | 0.0% (0/12) | 0.0% | 0.0% | | `lib/dto/auth.ts` | 0.0% (0/10) | 0.0% | 0.0% | | `lib/i18n/locales.ts` | 92.5% (49/53) | 92.5% | 94.3% | | `lib/i18n/request.ts` | 0.0% (0/31) | 0.0% | 0.0% | | `lib/i18n/set-locale-action.ts` | 0.0% (0/17) | 0.0% | 0.0% | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit 8c96b92f00 into main 2026-06-20 01:00:43 +00:00

james deleted branch 146-i18n 2026-06-20 01:00:43 +00:00

james referenced this pull request from a commit 2026-06-20 01:00:44 +00:00

Merge pull request 'feat(i18n): adopt next-intl + migrate every visible string (#146)' (#153) from 146-i18n into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!153

No description provided.