fix(ci): stamp app.json expo.version in the container build #292

Merged

james merged 2 commits from 291-web-version-stamp into main 2026-06-26 22:24:28 +00:00

Conversation 1 Commits 2 Files changed 2 +23 -7

james commented 2026-06-26 22:06:28 +00:00

Owner

Copy link

Follow-up to #290. The v0.0.1-rc.16 build still showed Carol 0.0.0 in the web/PWA settings footer even though it included #290.

Cause

release.yml's stamp step wrote the tag version into apps/api/package.json + root package.json, but not apps/client/app.json. The image builds the web client bundle with pnpm -F @carol/client export:web (Dockerfile ~line 79), which bakes app.json's expo.version into the bundle; the footer reads it at runtime via expo-constants. Unstamped → web bundle ships expo.version: 0.0.0.

The server /api/health (stamped via apps/api/package.json) and the Android APK (stamped via release-android.yml before prebuild) were already correct — only the web client surface was missed, and on web the footer shows just the client version.

Fix

Extend the "Stamp build version" step to also set apps/client/app.json expo.version before docker build (string only — versionCode is Android-only and handled by release-android.yml).

Verification

• actionlint .forgejo/workflows/release.yml — clean
• jq '.expo.version = "0.0.1-rc.16"' apps/client/app.json → 0.0.1-rc.16 ✓

Closes #291

🤖 Generated with Claude Code

Follow-up to #290. The `v0.0.1-rc.16` build still showed `Carol 0.0.0` in the web/PWA settings footer even though it included #290. ## Cause `release.yml`'s stamp step wrote the tag version into `apps/api/package.json` + root `package.json`, but not `apps/client/app.json`. The image builds the web client bundle with `pnpm -F @carol/client export:web` (Dockerfile ~line 79), which bakes `app.json`'s `expo.version` into the bundle; the footer reads it at runtime via `expo-constants`. Unstamped → web bundle ships `expo.version: 0.0.0`. The server `/api/health` (stamped via `apps/api/package.json`) and the Android APK (stamped via `release-android.yml` before prebuild) were already correct — only the **web client** surface was missed, and on web the footer shows just the client version. ## Fix Extend the "Stamp build version" step to also set `apps/client/app.json` `expo.version` before `docker build` (string only — `versionCode` is Android-only and handled by `release-android.yml`). ## Verification - `actionlint .forgejo/workflows/release.yml` — clean - `jq '.expo.version = "0.0.1-rc.16"' apps/client/app.json` → `0.0.1-rc.16` ✓ Closes #291 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james added 1 commit 2026-06-26 22:06:28 +00:00

fix(ci): stamp app.json expo.version in the container build ... 2c1b484bf0

The web client bundle is built inside the image via
`pnpm -F @carol/client export:web`, which bakes app.json's expo.version
into the bundle; the settings footer reads it at runtime via
expo-constants. release.yml's stamp step only wrote package.json and
apps/api/package.json, so the web bundle kept expo.version 0.0.0 and the
web/PWA footer showed `Carol 0.0.0` even on a real release (e.g.
v0.0.1-rc.16). Stamp apps/client/app.json's expo.version too (string
only; versionCode is Android-only and handled by release-android.yml).

Closes #291

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

james added 1 commit 2026-06-26 22:10:54 +00:00

feat(api): log app name and version at server startup ... ec097742ed

Print `[startup] Carol <version>` once when the server boots, in the
existing Next.js instrumentation register() hook (Node runtime only,
before migrations). Reads the version from the build-stamped
package.json, the same source /api/health uses. Pairs with the version
stamping in this PR so operators see the running release in the log.

Part of #291

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

forgejo-actions commented 2026-06-26 22:18:46 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	81.6% ✅	≥ 50%
Branches	72.8% ⚠️	≥ 75%
Functions	91.1%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 81.6% ✅ | ≥ 50% | | Branches | 72.8% ⚠️ | ≥ 75% | | Functions | 91.1% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit 1bebb8c5cb into main 2026-06-26 22:24:28 +00:00

james deleted branch 291-web-version-stamp 2026-06-26 22:24:28 +00:00

james referenced this pull request from a commit 2026-06-26 22:24:29 +00:00

Merge pull request 'fix(ci): stamp app.json expo.version in the container build' (#292) from 291-web-version-stamp into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!292

No description provided.