fix(ci): bump Flatpak Rust toolchain to 1.88.0 (#301) #302

Merged

james merged 1 commit from flatpak-rust-toolchain-188 into main 2026-06-26 23:14:52 +00:00

Conversation 1 Commits 1 Files changed 1 +9 -7

james commented 2026-06-26 23:08:09 +00:00

Owner

Copy link

Closes #301.

Problem

The Flatpak release build (run 758) fails at cargo build --locked:

error: rustc 1.85.0 is not supported by the following packages:
  darling@0.23.0 requires rustc 1.88.0
  serde_with@3.21.0 requires rustc 1.88
  plist@1.9.0 requires rustc 1.88.0
  time@0.3.49 requires rustc 1.88.0
  icu_*@2.2.0 / idna_adapter@1.2.2 require rustc 1.86

release-flatpak.yml pins RUST_TOOLCHAIN: 1.85.0, but the locked Cargo
dependency tree's MSRV has risen to 1.88.0. Because the build uses
--locked, cargo can't fall back to older crate versions — the toolchain must
satisfy the highest MSRV in the lockfile. Same class of failure as #293 / PR
#294 (1.77 → 1.85); the comment there anticipated this ("Bump deliberately if
the lockfile's MSRV rises again").

Fix

Bump RUST_TOOLCHAIN to 1.88.0 and refresh the explanatory comment to cite
the current binding crates (darling, serde_with, plist, time at 1.88;
icu_*/idna_adapter at 1.86).

Verification

• actionlint clean on the edited workflow.
• The toolchain pin (1.88.0) now meets the highest MSRV the error reported, so
  cargo build --locked resolution will succeed. Full end-to-end is the
  Flatpak release job itself, which runs on tag push.

🤖 Generated with Claude Code

Closes #301. ## Problem The Flatpak release build (run [758](https://forge.wynning.tech/james/carol/actions/runs/758/jobs/0/attempt/1)) fails at `cargo build --locked`: ``` error: rustc 1.85.0 is not supported by the following packages: darling@0.23.0 requires rustc 1.88.0 serde_with@3.21.0 requires rustc 1.88 plist@1.9.0 requires rustc 1.88.0 time@0.3.49 requires rustc 1.88.0 icu_*@2.2.0 / idna_adapter@1.2.2 require rustc 1.86 ``` `release-flatpak.yml` pins `RUST_TOOLCHAIN: 1.85.0`, but the locked Cargo dependency tree's MSRV has risen to **1.88.0**. Because the build uses `--locked`, cargo can't fall back to older crate versions — the toolchain must satisfy the highest MSRV in the lockfile. Same class of failure as #293 / PR #294 (1.77 → 1.85); the comment there anticipated this ("Bump deliberately if the lockfile's MSRV rises again"). ## Fix Bump `RUST_TOOLCHAIN` to `1.88.0` and refresh the explanatory comment to cite the current binding crates (`darling`, `serde_with`, `plist`, `time` at 1.88; `icu_*`/`idna_adapter` at 1.86). ## Verification - `actionlint` clean on the edited workflow. - The toolchain pin (1.88.0) now meets the highest MSRV the error reported, so `cargo build --locked` resolution will succeed. Full end-to-end is the Flatpak release job itself, which runs on tag push. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james added 1 commit 2026-06-26 23:08:09 +00:00

fix(ci): bump Flatpak Rust toolchain to 1.88.0 ... 1edb076c39

The locked Cargo dependency tree's MSRV rose above 1.85.0: darling
0.23.0, serde_with 3.21.0, plist 1.9.0, and time 0.3.49 now require
rustc 1.88.0 (icu_* 2.2.0 / idna_adapter 1.2.2 need 1.86). Since the
Flatpak build runs `cargo build --locked`, the toolchain must satisfy
the highest MSRV in the lockfile or resolution fails with
"rustc 1.85.0 is not supported by the following packages".

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

forgejo-actions commented 2026-06-26 23:14:38 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	81.6% ✅	≥ 50%
Branches	72.8% ⚠️	≥ 75%
Functions	91.1%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 81.6% ✅ | ≥ 50% | | Branches | 72.8% ⚠️ | ≥ 75% | | Functions | 91.1% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit 7f8198d5c7 into main 2026-06-26 23:14:52 +00:00

james deleted branch flatpak-rust-toolchain-188 2026-06-26 23:14:52 +00:00

james referenced this pull request from a commit 2026-06-26 23:14:54 +00:00

Merge pull request 'fix(ci): bump Flatpak Rust toolchain to 1.88.0 (#301)' (#302) from flatpak-rust-toolchain-188 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!302

No description provided.