feat(client): agent activity history UI — "what Carol changed" #351

Merged

james merged 1 commit from 350-activity-history-ui into main 2026-06-29 12:14:45 +00:00

Conversation 1 Commits 1 Files changed 9 +433 -1

james commented 2026-06-29 12:01:43 +00:00

Owner

Copy link

Makes the audit trail (#348, GET /api/agent/audit) user-visible: api-client hooks + a paginated, read-only activity screen showing every change Carol made, newest first. Undo is a separate follow-up.

What's in it

• @carol/api-client — useAuditLog() + useAuditLogInfinite() over /api/agent/audit, mirroring the conversations hooks; keys.auditLog.
• lib/activity/describeAuditEvent.ts — pure, tested mapper from an event's verb_noun action to a relative i18n verb key + the raw entity type.
• app/(app)/activity.tsx — a dedicated routable screen (out of the fixed sidebar, like notes.tsx), reached via a card in Settings. Cursor "load more", loading/error/empty branches, DS tokens, Carol's voice.
• account.tsx — an ActivityCard linking to /activity.
• i18n — new activity namespace (verb fragments + entity nouns); es.json untouched.

Two issues I caught and fixed during review (beyond the agent's output)

1. Rendering bug — full keys double-namespaced. The helper returned activity.verb.create but the screen renders via useTranslation("activity"), so t("activity.verb.create") resolved to the literal key string on screen (verified against the real i18n config — the node tests only assert the helper's return value, so they didn't catch it). Fixed by returning a relative key (verb.create).
2. Snake_case leaking into the UI. The entity noun was the raw entityType, so person_organization would render as "I created a person_organization". Now localized via an activity.entity.* catalog (person→"contact", person_note→"note", person_organization→"connection", profile→"profile") with a de-snaked fallback for future types. Verified end-to-end against the real i18n config:
   • person → "I created a contact" · person_note → "I added a note" · person_organization → "I deleted a connection" · profile → "I updated a profile" · unlabeled job → "I created a job" (fallback).

Verification (local)

• @carol/api-client: typecheck ✓ · lint ✓ · check ✓ (no spec/codegen change) · test ✓ 42
• @carol/client: typecheck ✓ · lint ✓ · test ✓ 154 (incl. updated describeAuditEvent cases)
• end-to-end i18n resolution checked against the real config (above); en.json valid
• semgrep (CI pack set) ✓ 0 findings on the new/changed files

⚠️ Needs maintainer verification (headless limit)

Client vitest is node-env — the visual screen (list, load-more, Settings card, navigation) needs a real PWA/device check.

Out of scope (follow-ups)

• Undo (backend reversal endpoint + an undo button here).
• before/after diff expansion; filtering. (Note: the empty/lede copy says "nothing here can be undone" — the undo ticket should update that line.)

Part of epic #47; makes #348 visible.

Closes #350

🤖 Generated with Claude Code

Makes the audit trail (#348, `GET /api/agent/audit`) user-visible: api-client hooks + a paginated, read-only activity screen showing every change Carol made, newest first. Undo is a separate follow-up. ## What's in it - **`@carol/api-client`** — `useAuditLog()` + `useAuditLogInfinite()` over `/api/agent/audit`, mirroring the conversations hooks; `keys.auditLog`. - **`lib/activity/describeAuditEvent.ts`** — pure, tested mapper from an event's `verb_noun` action to a relative i18n verb key + the raw entity type. - **`app/(app)/activity.tsx`** — a dedicated routable screen (out of the fixed sidebar, like `notes.tsx`), reached via a card in Settings. Cursor "load more", loading/error/empty branches, DS tokens, Carol's voice. - **`account.tsx`** — an `ActivityCard` linking to `/activity`. - **i18n** — new `activity` namespace (verb fragments + entity nouns); `es.json` untouched. ## Two issues I caught and fixed during review (beyond the agent's output) 1. **Rendering bug — full keys double-namespaced.** The helper returned `activity.verb.create` but the screen renders via `useTranslation("activity")`, so `t("activity.verb.create")` resolved to the **literal key string** on screen (verified against the real i18n config — the node tests only assert the helper's return value, so they didn't catch it). Fixed by returning a **relative** key (`verb.create`). 2. **Snake_case leaking into the UI.** The entity noun was the raw `entityType`, so `person_organization` would render as "I created a person_organization". Now localized via an `activity.entity.*` catalog (`person`→"contact", `person_note`→"note", `person_organization`→"connection", `profile`→"profile") with a de-snaked fallback for future types. Verified end-to-end against the real i18n config: - `person` → "I created a contact" · `person_note` → "I added a note" · `person_organization` → "I deleted a connection" · `profile` → "I updated a profile" · unlabeled `job` → "I created a job" (fallback). ## Verification (local) - `@carol/api-client`: typecheck ✓ · lint ✓ · `check` ✓ (no spec/codegen change) · test ✓ 42 - `@carol/client`: typecheck ✓ · lint ✓ · test ✓ 154 (incl. updated `describeAuditEvent` cases) - end-to-end i18n resolution checked against the real config (above); `en.json` valid - semgrep (CI pack set) ✓ 0 findings on the new/changed files ## ⚠️ Needs maintainer verification (headless limit) Client vitest is `node`-env — the **visual screen** (list, load-more, Settings card, navigation) needs a real PWA/device check. ## Out of scope (follow-ups) - **Undo** (backend reversal endpoint + an undo button here). - before/after diff expansion; filtering. (Note: the empty/lede copy says "nothing here can be undone" — the undo ticket should update that line.) Part of epic #47; makes #348 visible. Closes #350 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james added 1 commit 2026-06-29 12:01:43 +00:00

feat(client): agent activity history UI — "what Carol changed" ... c4569eb87d

Make the audit trail (#348, GET /api/agent/audit) user-visible: a
paginated, read-only activity screen showing every change Carol made,
newest first. Undo is a separate follow-up.

- @carol/api-client: useAuditLog() + useAuditLogInfinite() over
  /api/agent/audit, mirroring the conversations hooks; keys.auditLog.
- lib/activity/describeAuditEvent.ts: pure, tested mapper from an audit
  event's verb_noun action to a relative i18n verb key + the raw entity
  type.
- app/(app)/activity.tsx: a dedicated routable screen (out of the fixed
  sidebar, like notes.tsx), reached via a card in Settings. Localizes the
  entity noun via the activity catalog with a de-snaked fallback, so a
  type without a label never surfaces raw "person_organization".
- account.tsx: an ActivityCard linking to /activity.
- i18n: new activity namespace (verb fragments + entity nouns) in Carol's
  voice; es.json untouched.

The screen renders the description key with useTranslation("activity"),
so describeAuditEvent returns a RELATIVE key ("verb.create") — a full
"activity.verb.*" key would double-namespace and surface the raw key
string to users.

Closes #350

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

forgejo-actions commented 2026-06-29 12:08:12 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	79.3% ✅	≥ 50%
Branches	71.1% ⚠️	≥ 75%
Functions	80.3%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 79.3% ✅ | ≥ 50% | | Branches | 71.1% ⚠️ | ≥ 75% | | Functions | 80.3% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit f278e799cb into main 2026-06-29 12:14:45 +00:00

james deleted branch 350-activity-history-ui 2026-06-29 12:14:46 +00:00

james referenced this pull request from a commit 2026-06-29 12:14:47 +00:00

Merge pull request 'feat(client): agent activity history UI — "what Carol changed"' (#351) from 350-activity-history-ui into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!351

No description provided.