fix(client): give every edit button the pencil icon (#353) #358

Merged

james merged 1 commit from 353-standardize-edit-buttons into main 2026-06-29 13:14:57 +00:00

Conversation 1 Commits 1 Files changed 5 +75 -3

james commented 2026-06-29 13:01:29 +00:00

Owner

Copy link

Some edit buttons showed a Lucide pencil and others didn't. Standardize: every "edit" affordance now leads with <Pencil size={14}> before its label, matching the pattern already used in profile.tsx / projects.tsx.

Fixed

• notes.tsx (note-row edit), projects.tsx (ProjectRow edit), experience.tsx (8 edit buttons — skills section, contracts, contract position/contribution, education, jobs, job position/contribution), and the network person/org detail screens.
• The network detail screens edit through a shared local SecondaryButton; an optional icon prop was added so only the edit call sites get the pencil — every other SecondaryButton (cancel/save/delete/add) is unchanged.
• Canonical pattern matched from the buttons that already had it: leading <Pencil size={14} color={theme.tokens.text} strokeWidth={1.75} /> + flexDirection: "row" / gap: 6 on the button style.

Icon-only and decorative next to the existing label; colors via theme.tokens.*; no i18n, label, handler, or accessibility changes. Only apps/client touched.

Verification (local, re-run in the worktree)

• typecheck ✓ · lint ✓ · test ✓ 154 · semgrep ✓ 0 findings on the 5 changed files

⚠️ Needs maintainer verification

Client tests are node-env — the visual alignment/spacing of the icon across screens needs an eyeball in a running build.

Closes #353

🤖 Generated with Claude Code

Some edit buttons showed a Lucide pencil and others didn't. Standardize: every "edit" affordance now leads with `<Pencil size={14}>` before its label, matching the pattern already used in `profile.tsx` / `projects.tsx`. ## Fixed - `notes.tsx` (note-row edit), `projects.tsx` (ProjectRow edit), `experience.tsx` (8 edit buttons — skills section, contracts, contract position/contribution, education, jobs, job position/contribution), and the network person/org detail screens. - The network detail screens edit through a shared local `SecondaryButton`; an optional `icon` prop was added so only the edit call sites get the pencil — every other SecondaryButton (cancel/save/delete/add) is unchanged. - Canonical pattern matched from the buttons that already had it: leading `<Pencil size={14} color={theme.tokens.text} strokeWidth={1.75} />` + `flexDirection: "row"` / `gap: 6` on the button style. Icon-only and decorative next to the existing label; colors via `theme.tokens.*`; no i18n, label, handler, or accessibility changes. Only `apps/client` touched. ## Verification (local, re-run in the worktree) - `typecheck` ✓ · `lint` ✓ · `test` ✓ 154 · semgrep ✓ 0 findings on the 5 changed files ## ⚠️ Needs maintainer verification Client tests are `node`-env — the **visual** alignment/spacing of the icon across screens needs an eyeball in a running build. Closes #353 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james added 1 commit 2026-06-29 13:01:29 +00:00

fix(client): give every edit button the pencil icon (#353) ... 778c4f30dd

Some edit buttons showed a Lucide pencil and others didn't. Standardize:
every "edit" affordance now leads with `<Pencil size={14}>` before its
label, matching the pattern already used in profile.tsx / projects.tsx.

Fixed the edit buttons in notes, projects (row), experience (8 buttons —
skills/contracts/positions/contributions/education/jobs), and the
network person/org detail screens (via an optional `icon` prop on their
shared SecondaryButton, leaving the other buttons untouched). Icon-only,
decorative next to the existing label; colors via theme.tokens; no i18n
or behavior changes.

Closes #353

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

forgejo-actions commented 2026-06-29 13:09:08 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	79.3% ✅	≥ 50%
Branches	71.1% ⚠️	≥ 75%
Functions	80.5%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 79.3% ✅ | ≥ 50% | | Branches | 71.1% ⚠️ | ≥ 75% | | Functions | 80.5% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit 3f574aa71a into main 2026-06-29 13:14:57 +00:00

james deleted branch 353-standardize-edit-buttons 2026-06-29 13:14:58 +00:00

james referenced this pull request from a commit 2026-06-29 13:14:59 +00:00

Merge pull request 'fix(client): give every edit button the pencil icon (#353)' (#358) from 353-standardize-edit-buttons into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!358

No description provided.