fix(client): complete Android OAuth on cold start (#300) #383

Merged

james merged 1 commit from 300-oauth-cold-start into main 2026-06-29 18:11:49 +00:00

Conversation 1 Commits 1 Files changed 5 +377 -6

james commented 2026-06-29 17:55:21 +00:00

Owner

Copy link

Closes #300

PR #298 fixed the warm-path OAuth return, but a true cold start — the OS kills the app while the system browser is foreground — lost the in-memory waiter, so the return deep link was queued but never drained. The user landed back on /login unauthenticated.

What changed

• lib/auth/oauthDeepLink.ts: drainOauthDeepLink() — an atomic read-and-clear of the single pending slot.
• lib/auth/oauthColdStart.ts (new): pure, node-testable completeOauthColdStart with every side effect injected (drain, POST /api/auth/token, store tokens).
• app/_layout.tsx: the existing Linking.getInitialURL() handler now runs the cold-start completion and, on success, mirrors login.tsx (invalidate auth.me → router.replace("/chat")). Runs only on the getInitialURL branch, never on the warm addEventListener path.

Idempotency

A live warm waiter consumes the payload inline (pending stays null → drain no-ops); a cold start has no waiter (pending is set → drain + exchange exactly once). The init token is drained before the network call, so a failed exchange leaves nothing wedged. login.tsx (warm path) is deliberately untouched and is never double-exchanged.

Verification

• typecheck / lint clean, 182 tests pass (incl. 6 new cold-start + 4 drain/idempotency), semgrep 0.
• Cannot be verified headlessly — needs an Android device. Repro: Developer options → enable "Don't keep activities" → sign in via OAuth → expect the cold relaunch to land on /chat signed in. Re-confirm the warm path is not double-exchanged.

Merge note

Independent of #236/#239 — touches only the OAuth files + _layout.tsx (not login.tsx or server-setup.tsx). No conflicts.

🤖 Generated with Claude Code

Closes #300 PR #298 fixed the **warm**-path OAuth return, but a true **cold start** — the OS kills the app while the system browser is foreground — lost the in-memory waiter, so the return deep link was queued but never drained. The user landed back on `/login` unauthenticated. ## What changed - **`lib/auth/oauthDeepLink.ts`**: `drainOauthDeepLink()` — an atomic read-and-clear of the single pending slot. - **`lib/auth/oauthColdStart.ts`** (new): pure, node-testable `completeOauthColdStart` with every side effect injected (drain, POST `/api/auth/token`, store tokens). - **`app/_layout.tsx`**: the existing `Linking.getInitialURL()` handler now runs the cold-start completion and, on success, mirrors `login.tsx` (invalidate `auth.me` → `router.replace("/chat")`). Runs **only** on the `getInitialURL` branch, never on the warm `addEventListener` path. ## Idempotency A live warm waiter consumes the payload inline (pending stays `null` → drain no-ops); a cold start has no waiter (pending is set → drain + exchange exactly once). The init token is drained **before** the network call, so a failed exchange leaves nothing wedged. `login.tsx` (warm path) is deliberately untouched and is never double-exchanged. ## Verification - typecheck / lint clean, 182 tests pass (incl. 6 new cold-start + 4 drain/idempotency), semgrep 0. - **Cannot be verified headlessly — needs an Android device.** Repro: Developer options → enable "Don't keep activities" → sign in via OAuth → expect the cold relaunch to land on `/chat` signed in. Re-confirm the warm path is not double-exchanged. ## Merge note Independent of #236/#239 — touches only the OAuth files + `_layout.tsx` (not `login.tsx` or `server-setup.tsx`). No conflicts. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james added 1 commit 2026-06-29 17:55:21 +00:00

fix(client): complete Android OAuth on cold start (#300) ... fe806eee31

PR #298 fixed the warm-path return, but a true cold start (OS kills the
app while the system browser is foreground) lost the in-memory waiter, so
the return deep link was queued but never drained — the user landed on
/login unauthenticated.

Drain the deep-link queue at bootstrap, independent of any login.tsx
waiter:
- lib/auth/oauthDeepLink.ts: drainOauthDeepLink() — an atomic read-and-clear
  of the single pending slot.
- lib/auth/oauthColdStart.ts (new): pure, node-testable completeOauthColdStart
  with all side effects injected (drain, POST /api/auth/token, store tokens).
- app/_layout.tsx: the existing getInitialURL() handler runs the cold-start
  completion and, on success, mirrors login.tsx (invalidate auth.me →
  router.replace("/chat")). Runs ONLY on the getInitialURL branch.

Idempotent: a live warm waiter consumes inline (pending stays null → drain
no-ops); cold start has no waiter (pending set → drain + exchange once).
The init token is drained before the network call, so a failed exchange
leaves nothing wedged. Warm path (login.tsx) untouched, not double-exchanged.

Unit tests: queued payload → exactly one exchange; empty → no-op; warm +
bootstrap don't double-exchange; failed exchange leaves no half-consumed token.

Closes #300

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

forgejo-actions commented 2026-06-29 18:05:15 +00:00

Copy link

📊 Test coverage

Patch coverage: no testable lines changed.

Overall (app/, lib/, db/, excluding UI per ADR-0019):

Metric	Value	Soft target
Lines	79.6% ✅	≥ 50%
Branches	71.5% ⚠️	≥ 75%
Functions	80.8%	informational

Soft thresholds per ADR-0019. Coverage is informational and does not block merge.

<!-- coverage-comment --> ## 📊 Test coverage **Patch coverage:** no testable lines changed. **Overall** (`app/`, `lib/`, `db/`, excluding UI per ADR-0019): | Metric | Value | Soft target | |---|---|---| | Lines | 79.6% ✅ | ≥ 50% | | Branches | 71.5% ⚠️ | ≥ 75% | | Functions | 80.8% | informational | Soft thresholds per [ADR-0019](docs/adr/0019-coverage-soft-targets.md). Coverage is informational and does not block merge.

james merged commit 18f8ab458f into main 2026-06-29 18:11:49 +00:00

james deleted branch 300-oauth-cold-start 2026-06-29 18:11:50 +00:00

james referenced this pull request from a commit 2026-06-29 18:11:50 +00:00

Merge pull request 'fix(client): complete Android OAuth on cold start (#300)' (#383) from 300-oauth-cold-start into main

james referenced this pull request 2026-06-30 12:04:42 +00:00

Verify Android OAuth cold-start fix on a real device (#300 follow-up) #388

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area:auth

Authentication and authorization

  

area:ci

Forgejo Actions, build, test, security, release

  

area:db

Database abstraction, migrations, persistence

  

area:infra

Containerization, deployment, foundational tooling

  

area:native

React Native app (Android + Linux Flatpak)

  

area:pwa

PWA / web frontend

  

area:service

Backend service, API routes, persistence

  

epic

High-level tracker; links several feature tickets

  

feature

A user-facing feature

  

foundation

Foundational work that other tickets build on

No labels

area:auth

area:ci

area:db

area:infra

area:native

area:pwa

area:service

epic

feature

foundation

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

james/carol!383

No description provided.